fix: retry computed qrl execution when not ready #7470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new QRL component to handle inner computed QRL logic and add an e2e test to verify its behavior. The test ensures that the counter updates correctly without uncaught promises. Additionally, update the QRL class to use `retryOnPromise` for better error handling during QRL resolution.
🦋 Changeset detectedLatest commit: 9d50c28 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…be block The describe block was removed to streamline the test file and improve readability. The test logic remains unchanged, focusing on verifying the counter update functionality without uncaught promises.
commit: |
wmertens
requested changes
Apr 3, 2025
refactor(qrl): simplify promise handling in QRL class by removing redundant retryOnPromise
Member
|
weird, looks like it makes e2e hang :( does |
Contributor
Author
|
Yes. It's fine on my side. Let me try it on my own computer. But do it late |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Introduce a new QRL component to handle inner computed QRL logic and add an e2e test to verify its behavior. The test ensures that the counter updates correctly without uncaught promises. Additionally, update the QRL class to use `retryOnPromise` for better error handling during QRL resolution.
…be block The describe block was removed to streamline the test file and improve readability. The test logic remains unchanged, focusing on verifying the counter update functionality without uncaught promises.
refactor(qrl): simplify promise handling in QRL class by removing redundant retryOnPromise
…4/qwik into 7442_fix_promise_fail
Varixo
requested changes
Apr 6, 2025
Contributor
Author
|
@Varixo Now it's fine |
Varixo
changed the title
Varixo
approved these changes
Apr 7, 2025
wmertens
reviewed
Apr 8, 2025
| '@qwik.dev/core': patch | ||
| --- | ||
|
|
||
| FIX: Introduce retry logic for QRL resolution to handle potential promise retries, ensuring robustness in asynchronous operations. |
Contributor
Author
There was a problem hiding this comment.
what's problem here ?
github-project-automation
bot
moved this from Waiting For Review
to Done
in Qwik Development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
fixes #7442
feat(qrl): add e2e test and retry logic for QRL resolution
Add a new e2e test to verify QRL behavior without uncaught promises. Introduce retry logic for QRL resolution to handle potential promise retries, ensuring robustness in asynchronous operations.
Description
Checklist
pnpm change